Seed admin user from Config.json and fix config path case sensitivity for Linux - #1
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
… sensitivity for Linux Co-Authored-By: patrick.bradley <patrick.bradley@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: patrick.bradley <patrick.bradley@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes:
Configurable seed admin credentials (
ERPService.cs): The first admin user created during initial DB setup now reads credentials fromConfig.jsonunder aSeedUsersection, with fallback to the original defaults (erp@webvella.com/erp). To use custom credentials, add toConfig.json:Linux case-sensitivity fix (
Startup.cs,ErpMvcExtensions.cs): Changed config path from"config.json"to"Config.json"in both locations that load the config file, to match the actual filename on case-sensitive filesystems.Review & Testing Checklist for Human
ErpSettings.Configurationis always initialized beforeInitializeSystemEntities()runs — if not, the config reads will throw aNullReferenceExceptionSeedUsersection inConfig.json— the fallback defaults should match the original behavior when the section is absentConfig.jsonafter initial setup will not update the existing user — confirm this is acceptableSuggested test plan: Drop the database, start the app with a
SeedUsersection inConfig.json, verify login works with the configured credentials. Then drop the database again, remove theSeedUsersection, and verify login works with the original defaults (erp@webvella.com/erp).Notes
Config.jsonitself was not modified in this PR to avoid committing credentials to source control. TheSeedUsersection must be added manually to each deployment's config file.config.json→Config.jsoncase fix is a no-op on Windows (case-insensitive) but required for Linux/macOS.demo@cognition.ai/password123succeeded after adding theSeedUsersection to the localConfig.json.Link to Devin session: https://app.devin.ai/sessions/4869a007cd7540c8944b1a59d5a3b15d
Requested by: @patrickbradley-cog