Skip to content

Adding Dockerfile, update Dependencies for Python 3.12 #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

madduci
Copy link

@madduci madduci commented Jan 31, 2025

Update Dependencies for Python 3.12, added Dockerfile

Type of Change

  • Bug Fix
  • New Feature
  • Refactor
  • Documentation

Checklist

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written Documentation/Tests?
  • Have you read done your own code-review?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@defendable-hanspetter
Copy link

Great contribution. Thanks alot!

I was able to build the docker image, and terravision starts, but fails,

Checking Terraform Version...
sh: can't create terraform_version.txt: Permission denied
Unhandled error: <class 'FileNotFoundError'>, [Errno 2] No such file or directory: 'terraform_version.txt', <traceback object at 0x7f86bf923a80>

Unsure if broken or skill issue. I also documentation of how to use this tool via docker. Maybe this deserves a separate file with more instructions and examples?

@madduci
Copy link
Author

madduci commented Feb 28, 2025

Interesting, could you please share the exact commands that have you used and perhaps also a small test project that i can check against? With my tests i was able to use the Docker Image

@tafalls929
Copy link

Building this on windows I had to add dos2unix /opt/terravision/terravision in the dockerfile to convert the carriage returns, but I was able to get the container successfully built

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants