Bug 1395766: Very small font size for <rt> inside <rtc> when lang="zh… - #1
Open
patrickdark wants to merge 1 commit into
Open
Bug 1395766: Very small font size for <rt> inside <rtc> when lang="zh…#1patrickdark wants to merge 1 commit into
patrickdark wants to merge 1 commit into
Conversation
…-TW" See https://bugzilla.mozilla.org/show_bug.cgi?id=1395766. 1. Move `font-size: 50%` and ` -moz-min-font-size-ratio: 50%` to `rt` elements only (to the exclusion of `rtc` elements). 2. Remove Taiwanese Chinese font size rule (with `30%` values on the same properties) targeted at bopomofo. (Regarding item 2, the correct selector for bopomofo targeting is `:lang("*-Bopo")` (not `:lang(zh-TW)`) and can't be done properly without CSS4 Selectors "wildcard matching"; see https://drafts.csswg.org/selectors-4/#the-lang-pseudo. This also leads to weirdness where `zh`, `zh-Bopo`, `zh-Bopo-TW`, and `zh-TW` don't produce the same font size.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…-TW"
See https://bugzilla.mozilla.org/show_bug.cgi?id=1395766.
font-size: 50%and-moz-min-font-size-ratio: 50%tortelements only (to the exclusion ofrtcelements).30%values on the same properties) targeted at bopomofo.(Regarding item 2, the correct selector for bopomofo targeting is
:lang("*-Bopo")(not:lang(zh-TW)) and can't be done properly without CSS4 Selectors "wildcard matching"; see https://drafts.csswg.org/selectors-4/#the-lang-pseudo. This also leads to weirdness wherezh,zh-Bopo,zh-Bopo-TW, andzh-TWdon't produce the same font size.)