Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #17

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Dev #17

wants to merge 27 commits into from

Conversation

Jeruntu
Copy link
Contributor

@Jeruntu Jeruntu commented Jan 19, 2021

Features

  • Add new options
    • specify background color
    • set quickcontrols2 style with qtquickcontrols2.conf
  • Dummy data like qmlscene Loading Test Data
  • Shortcuts
    • F1 to launch popup with options (set background and control loaded item sizing behaviour)
    • F2 toggle visibility (maximized screen, full screen, default)
    • CTRL+Q quit application
  • Update documentation
  • Add install target for cmake project

It is long list and there are other small changes. Let me know if you would like to split it into smaller PR's.

Remove dependency on widgets module
Popup size is now equal to minimum size of the window
QT_QMAKE_EXECUTABLE is only defined in QtCreator
This is more explicit and consistent with the quick-controls-conf command.
File name is checked to be qhot-profile.json
By default item is stretched to the window size, otherwise window resizes to the loaded item.
Remove Shortcut F3, wasn't working anymore
@Jeruntu
Copy link
Contributor Author

Jeruntu commented Feb 16, 2021

Are you willing to include these features?

@patrickelectric
Copy link
Owner

Hi @Jeruntu, I'm tremendous sorry for the delay to answer and review your PR! Will do it today.

Copy link
Owner

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes are necessary, but the PR looks great! Thanks for the contribution!


import QtGraphicalEffects 1.0

import QtQml.Models 2.2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are necessary for windows deployment, without it the *deployqt binaries will not provide the necessary files to execute run these libraries.

@@ -0,0 +1,88 @@
# This file is used to ignore files which are generated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file contains a bunch of stuff that should not exist in this project, I think that is not a good idea to have it.

README.md Outdated

- **F1** Launch popup to change background
- **F2** Toggles visibility: maximized, full screen, back to default
- **F3** After changing window size, reset window to loaded component size
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the code they are ALT+F1, since ALT+F1 is a common shortcut between window managers, I believe that we should change the code to use only F1, F2 and etc.

@patrickelectric
Copy link
Owner

Hi @Jeruntu I fixed mostly of the commits and they are in master branch already, the visibility and stretch functionalities are still not there, since they need a bit of rebase and logic update to work with the master branch now, but I can do that in the next weekend if you don't do it until there.
I hope that you are doing fine!

@patrickelectric patrickelectric force-pushed the master branch 12 times, most recently from 1bdfa80 to 8b04a99 Compare March 12, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants