Skip to content

Changes for Microsoft Visual C++ compiler (2022) compatibility#33

Open
torsten-pf wants to merge 2 commits into
patrykcieslak:masterfrom
torsten-pf:master
Open

Changes for Microsoft Visual C++ compiler (2022) compatibility#33
torsten-pf wants to merge 2 commits into
patrykcieslak:masterfrom
torsten-pf:master

Conversation

@torsten-pf

Copy link
Copy Markdown
  • moved functions to SystemUtil.cpp to not include windows.h in other c++ files (preprocessor names collide)
  • replaced pragmas pack(1)...pack(0) with pack(push, 1)...pack(pop) (pack(0) does not reset the alignment)
  • variabe-length arrays are not supported
  • _USE_MATH_DEFINES must be set before cmath inclusion to get macros like M_PI, M_PI_2, ...
  • Tests: SDL requires "int main(int argc, char * argv[])" instead of "int main(int argc, const char * argv[])"

Right now all programs are running, but GUI elements (like checkboxes) do not show text

- moved functions to SystemUtil.cpp to not include windows.h in other c++ files (preprocessor names collide)
- replaced pragmas pack(1)...pack(0) with pack(push, 1)...pack(pop) (pack(0) does not reset the alignment)
- variabe-length arrays are not supported
- _USE_MATH_DEFINES must be set before cmath inclusion to get macros like M_PI, M_PI_2, ...
- Tests: SDL requires "int main(int argc, char * argv[])" instead of "int main(int argc, const char * argv[])"

Right now all programs are running, but GUI elements (like checkboxes) do not show text
@torsten-pf

Copy link
Copy Markdown
Author

I added a PR to Microsoft's STL implementation because it doesn't allow zero sigma in normal_distribution (microsoft/STL#3596).

If this will be rejected: Is it possible to use a very small sigma value where it is needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant