feat(index.js): export the layout helper so consumers can use layout.is('mobile') #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is('mobile')
affects: patternfly-react
This layout helper is used internally for the default stateful behavior of VerticalNav.
It would be
useful to expose for consumers who want to override parts of that state.
jeff-phillips-18
approved these changes
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affects: patternfly-react
What:
This layout helper is used internally for the default stateful behavior of VerticalNav.
It would be useful to expose for consumers who want to override parts of that state.
Link to Storybook:
Not relevant (no changes will be apparent in Storybook)
Additional issues:
@priley86 , this is necessary for part of the fix I was writing for patternfly/patternfly-react-demo-app#36 (#525). In order to lift
showMobileNavstate out, I want to uselayout.is('mobile')andlayout.addChangeListener()in the demo app, without having to pull in BreakJS directly.