Merged
Conversation
added 2 commits
January 12, 2025 16:59
…nto an assert credit to github user @trollkarlen for finding this. changed it to an assert since it should be caught in CI if it ever happens. while doing that, I detected that the unit test was not sufficient to cover the assert. the only consequence was that with SHA512 as checksum, an alarming output was printed. there was no missed/false duplicate detection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thanks to @trollkarlen (see #167) for finding this.
the consequences are mostly annoying: if run with SHA512 as checksum type, a printout is shown:
wrong answer from getDigestLength! FIXMEthis tells me almost noone uses the SHA512 option, at least not to the extent of getting annoyed and filing an issue.
I made the check into an assert and extended the unit test to trigger the interesting part of the code.