add progress option (closes #30) #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is based on the work by Markham in #190 I just modified it a tiny bit to use std::function instead of a raw function pointer. thanks! co-authored-by: Markham Anderson <[email protected]>
credit to Thomast Oster, see #42 co-authored-by: Thomas Oster <[email protected]>
pauldreik
force-pushed
the
progress-option
branch
from
b7a1e88 to
4847cfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @entrity and @t-oster for the work and the patience. This PR is built on top of your work in #42 and #190. I made some simplifications by using a std::function and caching the constant output, instead of a function pointer.
closes #30