Merged
Conversation
58b0c6d to
b6cf813
Compare
added 7 commits
February 15, 2026 16:31
this separates (most of) the implementation from the binary so it is possible to add unit tests.
this was never triggered in how rdfind used it.
b6cf813 to
c5f6c36
Compare
pauldreik
added a commit
that referenced
this pull request
Feb 15, 2026
there has so far only been tests on the finished binary (which is great) but for some things unit tests are better. I added this only to the cmake build since it is not fun at all working with autotools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there has so far only been tests on the finished binary (which is great) but for some things unit tests are better.
I added this only to the cmake build since it is not fun at all working with autotools.