Update lite-yt-embed.js, get the videoId onclick and before loading th… #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umbnail, to prevent null videoid bug
Author
|
@paulirish , thank you for this youtube web component. Do you think this fix is worthwhile? The use case we have is we want to follow angular standards in the template files, but this does not work with the LYT embed. This is because the connectionCallback is triggered before angular events. And since the videoId is reactive, this web component sees it as null on page load. This causes an error. It would be ideal that the video id supported reactive values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple fix allows the video id to be changed dynamically, such as a reactive property in angular.