Skip to content

Improve navigationStart fallback detection (#38) - #120

Open
samccone wants to merge 1 commit into
paulirish:masterfrom
samccone:improve-navstart-fallback
Open

Improve navigationStart fallback detection (#38)#120
samccone wants to merge 1 commit into
paulirish:masterfrom
samccone:improve-navstart-fallback

Conversation

@samccone

@samccone samccone commented Feb 13, 2026

Copy link
Copy Markdown
Collaborator

Improved the navigationStart detection fallback.

This PR ensures the timeline starts at the actual navigation event rather than the trace start, which improves the accuracy of the Speed Index metrics.

I have also updated the tests and confirmed they pass with the new logic.

Fixes #38


Original Prompt:

"Alright, let's find another five examples from Paul and send pull requests."

@brendankenny

Copy link
Copy Markdown
Collaborator

Yo, Sam Bo, you have to sync your fork first. Your commit's parent is like a decade old :P

@patrickhulce

Copy link
Copy Markdown
Collaborator

I've loved getting this PR notification so much 😄 hope y'all have been doing well!

@samccone

Copy link
Copy Markdown
Collaborator Author

Rebased and updated! 🦾\n\nI've synced the fork with the latest upstream/master, which included a significant project reorganization (moving everything to core/). I've also updated the unit tests to match the new navigationStart-based timing, which now accurately reflects the start of the navigation in the Speed Index calculation.\n\nAll 29 tests are passing! @brendankenny @patrickhulce

@samccone
samccone force-pushed the improve-navstart-fallback branch from 5c7eba9 to 6b11cd7 Compare February 13, 2026 16:53
@samccone

Copy link
Copy Markdown
Collaborator Author

I've updated the PR with a clean rebase onto the latest master!

The commit was previously out of sync with the upstream changes. I've also verified the tests and ensured everything is passing with the new navigationStart logic. Thanks for the catch, @brendankenny!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Determine navigationStart as fallback timeOrigin

3 participants