Skip to content

Better warnings for invalid TURN credentials #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Better warnings for invalid TURN credentials #289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/agent.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1299,21 +1299,21 @@ int agent_dispatch_stun(juice_agent_t *agent, void *buf, size_t size, stun_messa
case STUN_METHOD_ALLOCATE:
case STUN_METHOD_REFRESH:
if (agent_verify_credentials(agent, entry, buf, size, msg)) {
JLOG_WARN("Ignoring invalid TURN Allocate message");
JLOG_WARN("Ignoring TURN Allocate message with invalid credentials (Is server authentication disabled?)");
return -1;
}
return agent_process_turn_allocate(agent, msg, entry);

case STUN_METHOD_CREATE_PERMISSION:
if (agent_verify_credentials(agent, entry, buf, size, msg)) {
JLOG_WARN("Ignoring invalid TURN CreatePermission message");
JLOG_WARN("Ignoring TURN CreatePermission message with invalid credentials");
return -1;
}
return agent_process_turn_create_permission(agent, msg, entry);

case STUN_METHOD_CHANNEL_BIND:
if (agent_verify_credentials(agent, entry, buf, size, msg)) {
JLOG_WARN("Ignoring invalid TURN ChannelBind message");
JLOG_WARN("Ignoring TURN ChannelBind message with invalid credentials");
return -1;
}
return agent_process_turn_channel_bind(agent, msg, entry);
Expand Down
Loading