Skip to content

Prevent connectivity lost on non symmetric address #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025
Merged

Prevent connectivity lost on non symmetric address #306

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e68a85
Check non-symmetric addresses only on initial binding
paullouisageneau May 26, 2025
b29f833
Ensure selected entry is consistent on nominated entry state change
paullouisageneau May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/agent.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,6 +1078,7 @@ int agent_bookkeeping(juice_agent_t *agent, timestamp_t *next_timestamp) {
nominated_entry->state != AGENT_STUN_ENTRY_STATE_SUCCEEDED_KEEPALIVE) {
nominated_entry->state = AGENT_STUN_ENTRY_STATE_SUCCEEDED_KEEPALIVE;
agent_arm_keepalive(agent, nominated_entry);
atomic_store(&agent->selected_entry, nominated_entry); // for consistency
}

// If the entry of the nominated candidate is relayed locally, we need also to
Expand Down Expand Up @@ -1467,21 +1468,20 @@ int agent_process_stun_binding(juice_agent_t *agent, const stun_message_t *msg,
return -1;
}

// 7.2.5.2.1. Non-Symmetric Transport Addresses:
// The ICE agent MUST check that the source and destination transport addresses in the
// Binding request and response are symmetric. [...] If the addresses are not symmetric,
// the agent MUST set the candidate pair state to Failed.
if (!addr_record_is_equal(src, &entry->record, true)) {
JLOG_DEBUG(
"Candidate pair check failed (non-symmetric source address in response)");
entry->state = AGENT_STUN_ENTRY_STATE_FAILED;
entry->next_transmission = 0;
if (pair)
if (pair->state != ICE_CANDIDATE_PAIR_STATE_SUCCEEDED) {
// 7.2.5.2.1. Non-Symmetric Transport Addresses:
// The ICE agent MUST check that the source and destination transport addresses in
// the Binding request and response are symmetric. [...] If the addresses are not
// symmetric, the agent MUST set the candidate pair state to Failed.
if (!addr_record_is_equal(src, &entry->record, true)) {
JLOG_DEBUG(
"Candidate pair check failed (non-symmetric source address in response)");
entry->state = AGENT_STUN_ENTRY_STATE_FAILED;
entry->next_transmission = 0;
pair->state = ICE_CANDIDATE_PAIR_STATE_FAILED;
break;
}
break;
}

if (pair->state != ICE_CANDIDATE_PAIR_STATE_SUCCEEDED) {
JLOG_DEBUG("Candidate pair check succeeded");
pair->state = ICE_CANDIDATE_PAIR_STATE_SUCCEEDED;
}
Expand Down