Skip to content

Conversation

@paullouisageneau
Copy link
Owner

@paullouisageneau paullouisageneau commented Sep 26, 2025

This PR fixes/enhances multiple things related to the ICE-TCP implementation:

  • Implement ICE-TCP read and write with buffering, otherwise receiving a partial datagram from remote makes the poll loop spin, and sending when TCP socket buffer is full may write a partial datagram which breaks framing.
  • Fix out-of-bounds access to pfds array on agent destruction
  • Add two TCP active candidates for IPv6 and IPv4 to properly advertise IPv6 support
  • Populate socktype everywhere and compare socktypes to prevent confusion between UDP and TCP address
  • Refactor TCP connected callback and introduce state to handle connecting state

@Sean-Der Could you please test if things look good on your side with the changes?

@paullouisageneau paullouisageneau merged commit cdc4d4e into master Oct 19, 2025
3 checks passed
@paullouisageneau paullouisageneau deleted the ice-tcp-fixes branch October 19, 2025 19:45
@Dw9
Copy link

Dw9 commented Oct 20, 2025

lol,I should have checked the community submissions first. @paullouisageneau I’ve also recently implemented ice-tcp related features to support WebRTC over TCP.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants