Skip to content

Write description once #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aloxe wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Write description once #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a2984fe
create toggle to replicate Google description all over
aloxe Nov 24, 2021
2e987c0
use google description for twitter and facebook too
aloxe Nov 24, 2021
2ac2202
display alternate desc if needed
aloxe Nov 25, 2021
fba141c
display and save only N first chars for twitter and facebook
aloxe Nov 26, 2021
704a683
fix problem with google desc toggled not known
aloxe Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 51 additions & 41 deletions blueprints/seo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ form:
fields:
googlefields:
type: tab
title: Google
title: Google
fields:
header.googletitle:
type: text
Expand All @@ -26,13 +26,23 @@ form:
type: textarea
label: PLUGIN_SEO.GOOGLE_DESC
id: desc

header.googledescall:
type: toggle
label: PLUGIN_SEO.GOOGLE_DESC_ALL
highlight: 1
default: 0
options:
1: PLUGIN_ADMIN.YES
0: PLUGIN_ADMIN.NO
validate:
type: bool

header.googlepreview:
type: google
label: PLUGIN_SEO.GOOGLE_PREVIEWDESC
twitterfields:
type: tab
title: Twitter
title: Twitter
fields:
columns:
type: columns
Expand Down Expand Up @@ -72,7 +82,7 @@ form:
label: PLUGIN_SEO.TWITTER_SHAREIMG
preview_images: true
id: twittimgselect

header.twittertitle:
type: text
label: PLUGIN_SEO.TWITTER_TITLE
Expand All @@ -82,21 +92,21 @@ form:
style: vertical
label: PLUGIN_SEO.TWITTER_DESCRIPTION
id: twitterdescription


# .... subfields

column2:
type: column
fields:
header.twitterlabel:
type: section
text: PLUGIN_SEO.TWITTER_PREVIEWDESC

header.twitterpreview:
type: twitter
# .... other subfields

jsonfield:
type: tab
title: Microdata
Expand Down Expand Up @@ -231,7 +241,7 @@ form:
'http://schema.org/SoldOut': PLUGIN_SEO.SOLDOUT
'http://schema.org/OnlineOnly': PLUGIN_SEO.ONLINEONLY
field_classes: togglemusicevent

.musicevent_offers_url:
type: text
label: PLUGIN_SEO.TICKET_URL
Expand All @@ -248,7 +258,7 @@ form:
label: PLUGIN_SEO.PRICE_CURRENCY
field_classes: togglemusicevent
placeholder: USD

.musicevent_performer:
type: list
label: PLUGIN_SEO.ADD_PERFORMER
Expand All @@ -269,7 +279,7 @@ form:
type: text
label: Same as
placeholder: 'http://en.wikipedia.org/wiki/Artist_Page'
.musicevent_startdate:
.musicevent_startdate:
type: datetime
label: PLUGIN_SEO.MUSICEVENT_DATE_START
field_classes: togglemusicevent
Expand Down Expand Up @@ -357,7 +367,7 @@ form:
label: Link to official website of the organization
header.orga.logo:
type: text
label: Url to Organization Logo
label: Url to Organization Logo
placeholder: 'include http://'
header.orgaratingenabled:
type: toggle
Expand Down Expand Up @@ -467,7 +477,7 @@ form:
type: conditional
condition: "config.plugins.seo.event ? 'true' : 'false'"
fields:

header.eventfieldset:
type: fieldset
title: Event Microdata
Expand Down Expand Up @@ -498,7 +508,7 @@ form:
field_classes: toggleevent
.event_description:
type: text
label: PLUGIN_SEO.EVENT_DESCRIPTION
label: PLUGIN_SEO.EVENT_DESCRIPTION
field_classes: toggleevent
.event_startDate:
type: datetime
Expand Down Expand Up @@ -541,7 +551,7 @@ form:
fields:
header.personfieldset:
type: fieldset
title: Person Microdata
title: Person Microdata
collapsed: true
icon: address-card-o
collapsible: true
Expand Down Expand Up @@ -573,19 +583,19 @@ form:
field_classes: toggleperson
.person_address_addressLocality:
type: text
label: PLUGIN_SEO.PERSON_ADDRESS_LOCALITY
label: PLUGIN_SEO.PERSON_ADDRESS_LOCALITY
field_classes: toggleperson
.person_address_addressRegion:
type: text
label: PLUGIN_SEO.PERSON_ADDRESS_REGION
label: PLUGIN_SEO.PERSON_ADDRESS_REGION
field_classes: toggleperson
header.musicalbum_condition:
type: conditional
condition: "config.plugins.seo.musicalbum ? 'true' : 'false'"
fields:
header.musicalbumfieldset:
type: fieldset
title: Music Album Microdata
title: Music Album Microdata
icon: headphones
collapsed: true
collapsible: true
Expand Down Expand Up @@ -622,9 +632,9 @@ form:
field_classes: togglemusicalbum
.musicalbum_url:
type: text
label: PLUGIN_SEO.MUSICALBUM_URL
label: PLUGIN_SEO.MUSICALBUM_URL
field_classes: togglemusicalbum
.musicalbum_genre:
.musicalbum_genre:
type: text
label: PLUGIN_SEO.MUSICALBUM_GENRE
field_classes: togglemusicalbum
Expand All @@ -633,14 +643,14 @@ form:
label: PLUGIN_SEO.MUSICALBUM_TRACK_NUMBER
field_classes: togglemusicalbum
.musicalbum_track:
type: list
type: list
field_classes: togglemusicalbum
label: PLUGIN_SEO.MUSICALBUM_ADD_TRACK
default:
fields:
.position:
type: text
label: PLUGIN_SEO.MUSICALBUM_TRACK_POSITION
label: PLUGIN_SEO.MUSICALBUM_TRACK_POSITION
.name:
type: text
label: PLUGIN_SEO.MUSICALBUM_TRACK_NAME
Expand All @@ -657,7 +667,7 @@ form:
header.productfieldset:
type: fieldset
icon: shopping-bag
title: Product Microdata
title: Product Microdata
collapsed: true
collapsible: true
fields:
Expand All @@ -670,10 +680,10 @@ form:
1: PLUGIN_ADMIN.YES
0: PLUGIN_ADMIN.NO
validate:
type: bool
type: bool
header.product.name:
type: text
label: Name of the Product
label: Name of the Product
field_classes: togglerestaurant
header.product.category:
type: text
Expand Down Expand Up @@ -732,29 +742,29 @@ form:
.offer_price:
type: text
size: small
label: Price of the product
label: Price of the product
placeholder: "e.g: 19.99 (no currency symbol)"
.offer_validFrom:
type: datetime
label: Offer is valid from (optional)
.offer_validUntil:
type: datetime
label: Offer is valid until (optional)

.offer_priceCurrency:
label: PLUGIN_SEO.PRICE_CURRENCY
type: text
placeholder: USD


header.restaurant_condition:
type: conditional
condition: "config.plugins.seo.restaurant ? 'true' : 'false'"
fields:
header.restaurantfieldset:
type: fieldset
icon: cutlery
title: Restaurant Microdata
title: Restaurant Microdata
collapsed: true
collapsible: true
fields:
Expand All @@ -767,7 +777,7 @@ form:
1: PLUGIN_ADMIN.YES
0: PLUGIN_ADMIN.NO
validate:
type: bool
type: bool
header.restaurant.name:
type: text
label: PLUGIN_SEO.RESTAURANT_NAME
Expand Down Expand Up @@ -831,19 +841,19 @@ form:
fields:
.custom_json:
type: textarea
label: Or paste here your own JSON-ld Microdata
placeholder: (do not include the script tags)
label: Or paste here your own JSON-ld Microdata
placeholder: (do not include the script tags)
facebookfields:
type: tab
title: Facebook
title: Facebook
fields:
columns2:
type: columns
fields:
column3:
type: column
fields:

header.facebookenable:
type: toggle
label: PLUGIN_SEO.FACEBOOK_ENABLE
Expand All @@ -855,13 +865,13 @@ form:
0: PLUGIN_ADMIN.NO
validate:
type: bool

header.facebooktitle:
type: text
label: PLUGIN_SEO.FACEBOOK_TITLE
id: facebooktitle
placeholder: Will default to page title if left empty

header.facebookdesc:
type: textarea
style: vertical
Expand All @@ -878,7 +888,7 @@ form:
id: fbimgselect
label: PLUGIN_SEO.FACEBOOK_SHAREIMG
# .... subfields

column4:
type: column
fields:
Expand All @@ -887,17 +897,17 @@ form:
header.facebookpreview:
type: facebook
label: PLUGIN_SEO.FACEBOOK_PREVIEWDESC

# conditional_new_entries:
# type: conditional
# condition: "header.facebookenable ? 'false' : 'true'"
# classes: overlay bottom
#
#
# fields:
# field-a:
# label: New Field A
# type: text
#
#
# field-b:
# label: New Field B
# type: text
3 changes: 2 additions & 1 deletion languages/en.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ PLUGIN_SEO:
PLUGIN_STATUS: "Plugin status"
STATUS_HELP: "Set to false to disable this plugin completely."
GOOGLE_DESC: "Override Description"
GOOGLE_DESC_ALL: "Override all other empty descriptions with this one"
GOOGLE_TITLE: "Override Title"
GOOGLE_PREVIEWDESC: "Here is a preview of your page on Google results"
TWITTER_ENABLE: "Activate twitter card"
Expand Down Expand Up @@ -116,4 +117,4 @@ PLUGIN_SEO:
RESTAURANT_TELEPHONE: "Telephone"
ENABLE_PERSON: "Enable Person Microdata"
ENABLEORGA: "Enable Organization Microdata"
MUSICEVENT_URL_PLACEHOLDER: "Url to the official page of this music event"
MUSICEVENT_URL_PLACEHOLDER: "Url to the official page of this music event"
3 changes: 2 additions & 1 deletion languages/nl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ PLUGIN_SEO:
PLUGIN_STATUS: "Plugin status"
STATUS_HELP: "Zet op false om deze plugin volledig stop te zetten."
GOOGLE_DESC: "Overschrijf omschrijving"
GOOGLE_DESC_ALL: "Overschrijf ale andere lege omschrijvings met dese"
GOOGLE_TITLE: "Overschrijf titel"
GOOGLE_PREVIEWDESC: "Hier is een preview van jouw pagina in de google resultaten."
TWITTER_ENABLE: "Activeer twitter kaart"
Expand Down Expand Up @@ -116,4 +117,4 @@ PLUGIN_SEO:
RESTAURANT_TELEPHONE: "Telefoon"
ENABLE_PERSON: "Voeg persoon Microdata toe"
ENABLEORGA: "Voeg Organisatie Microdata toe"
MUSICEVENT_URL_PLACEHOLDER: "Url naar de officiële pagina van het muziek event"
MUSICEVENT_URL_PLACEHOLDER: "Url naar de officiële pagina van het muziek event"
1 change: 1 addition & 0 deletions languages/ro.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ PLUGIN_SEO:
PLUGIN_STATUS: "Status modul"
STATUS_HELP: "Setează ”fals” pentru a dezactiva acest modul complet."
GOOGLE_DESC: "Adaugă descrierea pentru Google"
GOOGLE_DESC_ALL: "Override all other empty descriptions with this one"

@aloxe aloxe Nov 26, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't translate Romanian

GOOGLE_TITLE: "Setează titlul pentru Google"
GOOGLE_PREVIEWDESC: "Acesta este previzualizarea paginii așa cum apare în rezultatele Google"
TWITTER_ENABLE: "Activează cardul Twitter"
Expand Down
Loading