[Refactor] Harden against pathological function names #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the regular expression for matching the function name to avoid potential quadratic runtime of the implementation of `Function.prototype.name` due to the regular expression in `es6-sham.js:157`. I'm not aware of any input that would trigger such behavior, however the fix in this case is trivial. In fact, both the leading `\s` and trailing `\s` in the regular expression are unnecessary (though, based on context, I would say the leading `\s` is actually necessary, however it currently isn't so...).
Collaborator
|
If there's no regression test I'm not sure it's worth fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the regular expression for matching the function name to avoid potential quadratic runtime of the implementation of
Function.prototype.namedue to the regular expression ines6-sham.js:157.I'm not aware of any input that would trigger such behavior, however the fix in this case is trivial. In fact, both the leading
\sand trailing\sin the regular expression are unnecessary (though, based on context, I would say the leading\sis actually necessary, however it currently isn't so...).See also es-shims/Function.prototype.name#37