Fixes related to mordents #1063
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In modern notation, mordent, upper mordent, and pralltriller are all the same and don't have the bar. Lower mordent has the cross bar.
|
Added forced semitone trillh, works either as !trillh! or t prefix to a note name. |
Was reversed compared to the ABC 2.1 spec
Was incorrect before compared to the ABC 2.1 spec
|
Added filtering of ABC file header inject |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pralltriller audio rendering (same as mordent)
Mordent, upper mordent, and pralltriller all should render the same notes and use the mordent symbol glyph with the crossbar.
Lower mordent uses the glyph with the vertical bar.
Details from:
https://en.wikipedia.org/wiki/Mordent