Typescript Migration #854
Open
Typescript Migration #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 24 commits
November 18, 2022 15:37
In the process of preparing the codemod that will operate the switch to typescript, I'm having to add eslint and prettier: both of these are going to be used by the codemod tool to format the code and detect types and errors at compile time. I do realize that Paul Rosen probably already has an eslintrc somewhere, I'm not re-adding it here. Would it be useful to have it included in the repo in the future? add prettier ignore config
switch hasOwnProperty to prototype.hasOwnProperty.call
convert errors to warnings
I'm switching webpack to compile TS files here. With the update, webpack compiles the library normally, but has some issues with the plugin version: it can't resolve the `TuneBook` import and for some reason, the logic of that component eludes me enough that I can't fix it right away.
Import the property directly from package.json was causing issues, so I had to find a way to use «require» instead of «import» for this one piece of data.
|
Hi Antoine, the first thing I notice is that you've requested a merge to I'll look at the actual code this week. |
|
Sounds good, I changed the destination! |
|
First thing I noticed is that the copyright notice is not on top of the abcjs-basic.min.js file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Absolutely don't merge this YET!
Hello Mr. Rosen,
Sorry to have been so MIA these past few months. I finally found some time to work on the switch to TS this week.
Here's the migration to typescript we had discussed. It's still in draft state, but I wanted to submit it to you asap, so you'd be able to object to anything that doesn't fly.
ts-migratefor the migration.requiresandmodules.exportstoimportsandexportspackage.json: project's "type" has been set to "module" in order to useimportsandexports. I don't know if this potentially breaks anything for users of the library? The output still uses es5, though.<script>imports in thehtmlfiles of the tests might require an "type=module" tagThat's all I have for now, I hope you'll find this PR useful!
Cheers