Archiver info tag #223
Open
Archiver info tag #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2024 17:03
Use 4 space for indentation
Align values for 3 and 4 letter fields
{ on same line as record
Space after commas
Remove trailing spaces
|
@mac-kan, do you think we should include a macro for the archiver policy? |
kivel
requested changes
Aug 27, 2024
I'd say it's mandatory to have it as a MACRO, otherwise you need to tinker with the template all the time, which is not really in the spirit of a module. |
I'm not aware that info fields create error. To my best knowledge, they are metadata that's consumed by a service that's actively looking for them. You'll get errors if the service can't find them, though. |
added 2 commits
September 2, 2024 19:12
- Fix minor bugs (missing quotes, unnecessary commands, etc) - Create ECMC_ARCHIVER_POLICY macro - Create configureArchiver.cmd
It is not used
kivel
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kivel and @anderssandstrom,
The guys here at ESS recently released a new feature that allow us to automatically register PVs for archival using info tags.
This PR adds support to said info tags. This means all ecmc IOCs at ESS can (can, not will, see below) be archived by default.
Initially I am only adding this to the motor record PV.
In the future, depending on success and/or necessity, we may want to expand this to other PVs.
The behavior is disabled by default. It will only work if
NAMING == ESSnamingand the integrator specify the archiver cluster via theECMC_ARCHIVERvariable (currently only 3 options are availabletn,ninandlab).I believe I wrote the code in such way that should not affect other facilities and is easily expandable if necessary.
But please let me know your thoughts.
PS1: please do not merge before @mac-kan agrees with the changes.
PS2: I took the opportunity to fix the formatting of the motor record
.dbfiles.PS3: I think I found a bug (?): The way it stands right now
ECMC_AXISFIELDINIThas no effect.https://github.com/paulscherrerinstitute/ecmccfg/blob/master/motion/ecmc_axis_mr.cmd#L21-L22
PS4: I set up a virtual axis that has been constantly moving... It amounts to approx. 1.5 GB per year of data usage with
.RBVbeing the main culprit.