Update to bincode v2 #720

intendednull · 2025-03-31T19:24:23Z

derive bincode::{Encode, Decode} for Decimal
update tests
bincode v2 bumps msrv to 1.85

`bincode_serialization_serde_float` is failing when the serde-arbitrary-precision feature is active, but passes when only serde-with-arbitrary-precision is active instead. cargo test --features serde-str,serde-float,serde-arbitrary-precision serde::test::bincode

intendednull · 2025-04-05T23:55:46Z

One test does not pass when "serde-arbitrary-precision" is set. It does pass when "serde-with-arbitrary-precision" is set, and not "serde-arbitrary-precision". Something to do with the serde_json encoding I think, will keep looking.

test serde::test::bincode_serialization_serde_float ... FAILED

failures:

---- serde::test::bincode_serialization_serde_float stdout ----
[src/serde.rs:548:38] &self.to_string() = "0"

thread 'serde::test::bincode_serialization_serde_float' panicked at src/serde.rs:708:88:
called `Result::unwrap()` on an `Err` value: UnexpectedEnd { additional: 6 }

intendednull · 2025-04-06T00:01:11Z

src/serde.rs

            assert_eq!(value, decoded);
-            assert_eq!(8usize + raw.len(), encoded.len());
+            assert_eq!(1usize + raw.len(), encoded.len());


Not sure this is correct. I checked the str serialization path is running, but I'm fuzzy with the internal representation. Not sure why it would be smaller tbh

intendednull · 2025-04-06T00:08:48Z

I've kept all the serde tests using the serde traits. Maybe we should add tests using the bincode Encode/Decode traits as well

cherryman and others added 2 commits March 11, 2025 21:25

Derive bincode::{Encode, Decode} for Decimal

d4ad254

Fix most bincode tests

a2c2e17

`bincode_serialization_serde_float` is failing when the serde-arbitrary-precision feature is active, but passes when only serde-with-arbitrary-precision is active instead. cargo test --features serde-str,serde-float,serde-arbitrary-precision serde::test::bincode

intendednull commented Apr 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to bincode v2 #720

Update to bincode v2 #720

intendednull commented Mar 31, 2025 •

edited

Loading

intendednull commented Apr 5, 2025 •

edited

Loading

intendednull Apr 6, 2025 •

edited

Loading

intendednull commented Apr 6, 2025 •

edited

Loading

Update to bincode v2 #720

Are you sure you want to change the base?

Update to bincode v2 #720

Conversation

intendednull commented Mar 31, 2025 • edited Loading

intendednull commented Apr 5, 2025 • edited Loading

intendednull Apr 6, 2025 • edited Loading

Choose a reason for hiding this comment

intendednull commented Apr 6, 2025 • edited Loading

intendednull commented Mar 31, 2025 •

edited

Loading

intendednull commented Apr 5, 2025 •

edited

Loading

intendednull Apr 6, 2025 •

edited

Loading

intendednull commented Apr 6, 2025 •

edited

Loading