fix: remove shadow band and scrollbar track in mobile flyout#15
Open
dereklputnam wants to merge 1 commit intopaviliondev:mainfrom
Open
fix: remove shadow band and scrollbar track in mobile flyout#15dereklputnam wants to merge 1 commit intopaviliondev:mainfrom
dereklputnam wants to merge 1 commit intopaviliondev:mainfrom
Conversation
Two visual artifacts appear in the mobile/narrow flyout panel: 1. **Trailing shadow band** — `@include dropdown` includes `box-shadow: 0 12px 12px rgb(0 0 0 / 15%)`. On the desktop dropdown (max-width: 280px) this looks natural. But the mobile flyout is `position: fixed; width: 100%`, so the same shadow spans the full viewport width, rendering as a dark semi-transparent bar below the last link — most visible in dark mode. Fix: override `box-shadow: none`. 2. **Horizontal scrollbar track** — `overflow: scroll` forces both x and y scrollbar tracks to always render. The horizontal track (~15px) sits at the bottom of the flyout and is visually indistinguishable from an extra padding band. Fix: `overflow-y: auto; overflow-x: hidden`. Generated with AI Co-Authored-By: Claude Code <ai@netwrix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two visual artifacts appear in the mobile flyout panel (
.mobile-view .top-level-links), both most noticeable in dark mode:Trailing shadow band —
@include dropdownincludesbox-shadow: 0 12px 12px rgb(0 0 0 / 15%). On the desktop dropdown this looks natural (small floating box, max-width 280px). But the mobile flyout isposition: fixed; width: 100%, so the shadow spans the full viewport width and appears as a dark semi-transparent bar below the last link. Fix: addbox-shadow: noneto override the mixin in this context.Horizontal scrollbar track —
overflow: scrollforces both x and y scrollbar tracks to always render. The horizontal track (~15px tall) appears at the bottom of the flyout and is visually indistinguishable from extra padding, even when there is nothing to scroll horizontally. Fix:overflow-y: auto; overflow-x: hidden.Changes
Only
mobile/mobile.scssis modified — one property changed, one property added, with comments explaining the root cause of each.Test plan
Generated with AI
Co-Authored-By: Claude Code ai@netwrix.com