Moonraker filament type parsing fix#355
Closed
gaaat98 wants to merge 2 commits intopaxx12:developfrom
Closed
Conversation
Owner
|
@gaaat98 Thanks. I will wait for upstream to merge patch, then will pick the patch and maintain it moving forward. |
✅ Build ArtifactsVersion:
|
Author
|
@paxx12 the developer of moonraker answered my PR and apparently the issue was already addressed in moonraker (Arksine/moonraker@3a54161) and it's still present in the U1 because an older version of moonraker is used, it looks like we need to wait for Snapmaker to update it as the fixed version returns JSON instead of plaintext and I cannot find where this output is processed by the firmware :( |
Owner
|
I will backport this patch, will ask you to review. |
paxx12
added a commit
that referenced
this pull request
Mar 29, 2026
Backports upstream commit 3a54161 to return filament_name and filament_type as JSON arrays for multi-material slices, fixes #355. Also restructures patch paths under home/lava/moonraker/ to match the target filesystem layout.
Owner
|
Replaced by #355 which does backport from Moonraker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is something that deserves a firmware patch, but it fixes a bug that results in filament type mismatches when there is a space in the filament type provided by the slicer, which in turn blocks filament selection from the Snapmaker U1 print UI.
More details here: Arksine/moonraker#1066
Ideally, Snapmaker could fix it by updating Moonraker once (and if) my fix is merged there, but who knows if that will ever happen.