Merged
Conversation
Contributor
Author
|
Waiting for #55 to restructure |
paxx12
reviewed
Dec 17, 2025
|
|
||
| printf ">> Installing latest curl from precompiled tarball\n" | ||
|
|
||
| REPO_URL=https://github.com/stunnel/static-curl |
Owner
There was a problem hiding this comment.
Can we similar to other put a static URL, with SHA256SUM?
wget it into tmp/ if not existing, unpack this.
The reason for this is:
- At some point we tested a specific version to behave as expected. This is guarded by the version and sha256 so we have a clear SBOM and prevent someone changing our depdendency for whatever reasons. In the end us shipping the firmware to user machines should ensure that we do not introduce malicious binaries.
- Curl is not supposed to change very frequently, in general it is better to have some dependency bot to update the dependency as part of PR instead of pulling from latest. I think we could probably have copolit periodically look at those things.
Owner
|
@horzadome Can you rebase? |
paxx12
reviewed
Dec 17, 2025
paxx12
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning:
There is no curl in stock firmware.
We would like to have curl available so that we can e.g. interact with Moonraker API. Specifically, in future PR I'll make adding/removing USB camera to Moonraker on hotplug so that users don't have to manually add it to Moonraker/Fluidd.
Curl is installed from latest binary release of https://github.com/stunnel/static-curl (Travis Lee). This download location is featured at https://curl.se/download.html so it's reliable enough for us to use.