Update Stripe retry_failed_payment api access to payment intent#1225
Open
mguidetti wants to merge 1 commit intopay-rails:mainfrom
Open
Update Stripe retry_failed_payment api access to payment intent#1225mguidetti wants to merge 1 commit intopay-rails:mainfrom
retry_failed_payment api access to payment intent#1225mguidetti wants to merge 1 commit intopay-rails:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary:
Fix
retry_failed_paymentfor Stripe API versions > 2025-03-31Related Issue:
Description:
Stripe API 2025-03-31 added support for multiple payments to invoices and removed the
payment_intentfield from the Invoice object in favor of the payments collection (https://docs.stripe.com/changelog/basil/2025-03-31/add-support-for-multiple-partial-payments-on-invoices)retry_failed_paymentwas referencinginvoice.payment_intent, which raises aNoMethodErroron Stripe API versions >= 2025-03-31.This PR changes
retry_failed_paymentto access the payment intent through thepaymentscollection instead. It selects the first payment using.first, so this doesn't actually support multiple payments like the API does, but perhaps this is fine for this gem's current purposes?Testing:
I didn't find any existing tests for this method and was unsure the best way to test it.
Screenshots (if applicable):
Checklist:
Additional Notes: