Allow Building with Java 25 and Use javac -release#7971
Open
Pandrex247 wants to merge 9 commits intopayara:mainfrom
Open
Allow Building with Java 25 and Use javac -release#7971Pandrex247 wants to merge 9 commits intopayara:mainfrom
javac -release#7971Pandrex247 wants to merge 9 commits intopayara:mainfrom
Conversation
Credit to luiseufrasio Annotation processing must be explicitly enabled. Without this, processors declared as regular dependencies (not in annotationProcessorPaths) are silently skipped, causing missing generated resources (e.g. LogMessages.properties) at runtime.
This is probably the "safer" and "more correct" option for what we're going for (enforcing compatibility with Java 21 regardless of the compiling Java version).
Leaves some of the quicklook ones alone as they're not inheriting from the parent - will tackle them separately
We don't care which thread ID it's using here - it's not pertinent to any of the tests It apparently doesn't run on Thread 1 for Java 25 ¯\_(ツ)_/¯
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows you to build the server with Java 25.
Also switches us over to using the
releaseoption of javac instead of-sourceand-target, as it's more in line with what we want to enforce (that even if you build with Java 25 or higher that the end runtime should be compatible with Java 21). This included cleaning up various redundant compiler configurations.Important Info
Blockers
None
Testing
New tests
None
Testing Performed
Built the server with Java 25, allowing unit tests to run - all good.
Started the server and loaded the admin console using java 25 - all good.
Switched over to Java 21, started the server and loaded the admin console (without rebuilding) - all good.
Testing Environment
Windows 11, Zulu JDK 25.0.2 and 21.0.10
Documentation
N/A
Notes for Reviewers
None