Skip to content

Feat/intent #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Feat/intent #474

wants to merge 5 commits into from

Conversation

onahprosper
Copy link
Collaborator

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.

Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, contracts etc.

References

Include any links supporting this change such as a:

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this project has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation and tests for new/changed functionality in this PR
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

By submitting a PR, I agree to Paycrest's Contributor Code of Conduct and Contribution Guide.

@onahprosper onahprosper self-assigned this May 23, 2025
@onahprosper onahprosper requested review from chibie and sundayonah May 23, 2025 00:26
@onahprosper onahprosper mentioned this pull request May 23, 2025
Open
@onahprosper
refactor: update TestGetAssetsByNetworkID to simplify expected symbol…
3ba0bb7 
…s and assertions
@onahprosper
feat: add intent network identifier and amount out fields to ReceiveA…
4996ea0 
…ddress

- Added `intent_network_identifier` and `intent_amount_out` fields to the ReceiveAddress schema.
- Updated mutation methods to handle new fields, including setters, getters, and clear/reset functions.
- Enhanced the ReceiveAddressCreate and ReceiveAddressUpdate functionalities to support new fields.
- Implemented predicates for querying based on the new fields.
- Updated the NewPaymentOrderPayload to include `intentNetworkIdentifier`.
- Modified intent metadata to include network information for various assets.
@onahprosper onahprosper marked this pull request as ready for review May 23, 2025 08:09
@onahprosper onahprosper requested a review from 5ran6 as a code owner May 23, 2025 08:09
@onahprosper onahprosper marked this pull request as draft May 26, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibie chibie Awaiting requested review from chibie chibie is a code owner

@sundayonah sundayonah Awaiting requested review from sundayonah

@5ran6 5ran6 Awaiting requested review from 5ran6 5ran6 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@onahprosper onahprosper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save previous provider rates in priority queue to reduce order failures
1 participant
@onahprosper