feat: implement provide profile availability #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibie
requested changes
Jun 10, 2025
Comment on lines
+1126
to
+1127
| // Remove: providerprofile.IsAvailableEQ(true), | ||
| // Add: providerprofile.AvailableForContains(institution.Edges.FiatCurrency.Code), |
Comment on lines
+65
to
+66
| // Remove: providerprofile.IsAvailable(true), | ||
| // The currency filter will be handled in CreatePriorityQueueForBucket |
Comment on lines
+540
to
+541
| // Remove: providerprofile.IsAvailableEQ(true), | ||
| // Add: providerprofile.AvailableForContains(bucketCurrency.Code), |
Comment on lines
+1345
to
+1346
| // providerprofile.IsAvailableEQ(true), // REMOVE this line | ||
| providerprofile.AvailableForContains(currency.Code), // ADD this line |
Comment on lines
+477
to
+478
| // .SetIsAvailable(payload["is_available"].(bool)). // REMOVE this line | ||
| SetAvailableFor(payload["available_for"].([]string)). // ADD this line |
| @@ -457,7 +457,7 @@ func CreateTestProviderProfile(overrides map[string]interface{}) (*ent.ProviderP | |||
| "provision_mode": "auto", | |||
| "is_partner": false, | |||
| "visibility_mode": "public", | |||
| "is_available": true, | |||
| "available_for": []string{"USD"}, // <-- Use available_for instead of is_available | |||
| @@ -876,7 +876,7 @@ func (s *IndexerService) IndexOrderRefundedTron(ctx context.Context, order *ent. | |||
| logger.WithFields(logger.Fields{ | |||
| "Error": fmt.Sprintf("%v", err), | |||
| "TxHash": order.TxHash, | |||
| }).Errorf("Failed to fetch event logs for %s", order.Edges.Token.Edges.Network.Identifier) | |||
| }).Errorf("Failed to fetch trx info by id for %s", order.Edges.Token.Edges.Network.Identifier) | |||
| @@ -885,7 +885,7 @@ func (s *IndexerService) IndexOrderRefundedTron(ctx context.Context, order *ent. | |||
| logger.WithFields(logger.Fields{ | |||
| "Error": fmt.Sprintf("%v", err), | |||
| "Response": data, | |||
| }).Errorf("Failed to parse JSON response for %s after fetching event logs", order.Edges.Token.Edges.Network.Identifier) | |||
| }).Errorf("Failed to parse JSON response for %s", order.Edges.Token.Edges.Network.Identifier) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the test utilities to support the new provider availability model, as part of the migration from a boolean
is_availablefield to a currency-specificavailable_forarray. All test helpers and test data creation now useavailable_for(an array of ISO currency codes) to set and assert provider availability. This aligns the test setup with the new business logic, ensuring that providers can be tested for availability on a per-currency basis.Key changes:
IsAvailableand theis_availablefield from test helpers.AvailableForand theavailable_forfield for currency-specific provider availability.available_foras an array of ISO currency codes.This change is required for the new matching logic and API, and ensures that tests accurately reflect the updated provider profile structure.
References
Testing
All unit and integration tests have been updated to use the new
available_forfield.Manual testing:
Developed and tested on Go 1.21, Postgres 14, MacOS 14, and Docker Compose environment.
This change adds test coverage for new/changed/fixed functionality
Checklist
mainBy submitting a PR, I agree to Paycrest's Contributor Code of Conduct and Contribution Guide.