fix: update decimal handling in voyager service for improved accuracy

[sundayonah]

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.

Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, contracts etc.

References

Include any links supporting this change such as a:

• GitHub Issue/PR number addressed or fixed e.g closes Save previous provider rates in priority queue to reduce order failures #407
• StackOverflow post
• Support forum thread
• Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this project has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

• This change adds test coverage for new/changed/fixed functionality

Checklist

• I have added documentation and tests for new/changed functionality in this PR
• All active GitHub checks for tests, formatting, and security are passing
• The correct base branch is being used, if not main

By submitting a PR, I agree to Paycrest's Contributor Code of Conduct and Contribution Guide.

Summary by CodeRabbit

• Bug Fixes
  • Improved precision handling for token decimal calculations in transfer operations to ensure accurate value conversions and validation.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The TransformVoyagerTransferToRPCFormat function's tokenDecimals variable type is changed from int to float64. This modifies how the extracted decimals value is handled in subsequent validation and decimal conversion operations, while the overall function logic remains unchanged.

Changes

Cohort / File(s)	Change Summary
Decimal Type Update services/voyager.go	Changed tokenDecimals extraction from int to float64 in TransformVoyagerTransferToRPCFormat, affecting type handling in validation and decimal conversion operations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify the type change from int to float64 is intentional and aligns with downstream calculations
• Confirm no precision or rounding issues arise from the type conversion
• Check that validation logic and ToSubunit calculation handle float64 correctly

Possibly related PRs

• fix: update indexing logic for Starknet and Voyager services #623: Modifies the same TransformVoyagerTransferToRPCFormat function in services/voyager.go, adding an Infof log statement for Voyager transfer fields alongside this type change.

Suggested reviewers

• chibie
• 5ran6
• onahprosper

Poem

🐰 A decimal dance, from whole to part,
Where integers once played their part!
Now floats take flight with graceful care,
More precise calculations fill the air! ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/decimals-float64

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1aedd23 and 07f67cd.

📒 Files selected for processing (1)

• services/voyager.go (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}