fix(order): split payment order settling logic for improved clarity #640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the logic for parsing the
splitOrderIdin theUpdateOrderStatusSettledfunction to handle Starknet networks differently. This ensures that the order ID is parsed correctly based on the network type.Network-specific order ID parsing:
UpdateOrderStatusSettledinservices/common/order.goto parseevent.SplitOrderIddirectly as a UUID for Starknet networks, while retaining the previous hex decoding logic for other networks.References
Testing
Checklist
mainBy submitting a PR, I agree to Paycrest's Contributor Code of Conduct and Contribution Guide.