Fix-validateOrderAmountAgainstProviderLimit #644
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
onahprosper
commented
Jan 8, 2026
onahprosper
commented
- Added validation for minimum and maximum order amounts before assignment, ensuring compliance with provider configurations.
- Implemented checks for OTC limits when order amounts exceed regular maximums, setting order types accordingly.
- Enhanced error logging for scenarios where orders are skipped due to amount violations, improving traceability and debugging.
added 2 commits
January 8, 2026 15:33
- Added logic to reload the provider currency entity after attempting to fix balance inconsistencies, ensuring updated values are retrieved from the database. - Improved error handling for the reload operation to provide clearer feedback in case of failure.
- Added validation for minimum and maximum order amounts before assignment, ensuring compliance with provider configurations. - Implemented checks for OTC limits when order amounts exceed regular maximums, setting order types accordingly. - Enhanced error logging for scenarios where orders are skipped due to amount violations, improving traceability and debugging.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.