Skip to content

feat: update Gateway contract for order settlement logic #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: update Gateway contract for order settlement logic #65

wants to merge 1 commit into from

Conversation

onahprosper
Copy link
Collaborator

  • Added console artifact and debug JSON files for Hardhat.
  • Modified Gateway contract to use currentBPS for liquidity provider calculations during order settlement.
  • Updated package.json test scripts to reflect new test file paths.
  • Enhanced gateway.settleOrder tests to include order creation and settlement for multiple liquidity providers.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.

Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, contracts etc.

References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed e.g closes #407
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this project has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

By submitting a PR, I agree to Paycrest's Contributor Code of Conduct and Contribution Guide.

@onahprosper
feat: update Gateway contract for order settlement logic
85156b2 
- Added console artifact and debug JSON files for Hardhat.
- Modified Gateway contract to use currentBPS for liquidity provider calculations during order settlement.
- Updated package.json test scripts to reflect new test file paths.
- Enhanced gateway.settleOrder tests to include order creation and settlement for multiple liquidity providers.
@onahprosper onahprosper requested a review from chibie as a code owner June 5, 2025 19:33
@onahprosper onahprosper self-assigned this Jun 5, 2025
@onahprosper onahprosper added bug Something isn't working deployment Deployment task labels Jun 5, 2025
dumbdevss
dumbdevss reviewed Jun 8, 2025
View reviewed changes
Copy link

@dumbdevss dumbdevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation solves the bug and ensures complete settlement of multiple-settled orders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dumbdevss dumbdevss dumbdevss left review comments

@chibie chibie Awaiting requested review from chibie chibie is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@onahprosper onahprosper

Labels
bug Something isn't working deployment Deployment task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onahprosper @dumbdevss