Skip to content

feat(next): updated version view #12027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

feat(next): updated version view #12027

wants to merge 37 commits into from

Conversation

AlessioGr
Copy link
Member

@AlessioGr AlessioGr commented Apr 7, 2025

#11769 improved the lexical version view diff component. This PR improves the rest of the version view.

What changed

  • Column layout when selecting a version:
    • Previously: Selected version on the left, latest version on the left
    • Now: Previous version on the left, previous version on the right (mimics behavior of GitHub)
  • Locale selector now displayed in pill selector, rather than react-select
  • Smoother, more reliable locale, modifiedOnly and version selection. Now uses clean event callbacks rather than useEffects
  • React-diff-viewer-continued has been replaced with the html differ we use in lexical
  • Updated Design for all field diffs
  • Version columns now have a clearly defined separator line
  • Fixed collapsibles showing in version view despite having no modified fields if modifiedOnly is true

Screenshots

Before

CleanShot 2025-04-11 at 20 10 03@2x

CleanShot 2025-04-11 at 20 10 28@2x

After

CleanShot 2025-04-11 at 20 02 22@2x

CleanShot 2025-04-11 at 20 02 47@2x

@AlessioGr AlessioGr changed the title refactor(next): updated version view feat(next): updated version view Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant