feat: open prevent page leave modal on browser back button navigation #12061
+96
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LimChorngUan
changed the title
|
Would address #11964 |
LimChorngUan
force-pushed
the
prevent-leave-on-back-nav
branch
from
e7a9244 to
4448c42
Compare
Implemented a workaround to show the "prevent leave" modal when users click the browser back button with unsaved changes. This solution addresses a limitation in Next.js App Router which doesn't provide built-in hooks for intercepting browser history navigation events. Technical details: - Creates a duplicate history entry as a buffer to prevent immediate back navigation, allowing the prevent leave modal to be displayed. - Uses history.go(-2) to properly navigate when user confirms leaving - Re-establishes buffer state when user cancels navigation Note: This implementation specifically targets the browser back button use case, which covers the vast majority of user navigation patterns. Forward button navigation is not supported by this workaround, but I think this is an acceptable trade-off considering the complexity of fully emulating the browser's history behavior within a Next.js application.
LimChorngUan
force-pushed
the
prevent-leave-on-back-nav
branch
from
4448c42 to
4671702
Compare
|
This solution feels really hacky and there're so many edge cases that would lead to bugs due to the duplicated history entry. It's a rabbit hole. Would appreciate if I could get some consultation how to best fix this. |
|
Next 15.3 now released with an onNavigate hook that would enable us to cleanly implement this |
|
onNavigate is an event handler of the Link component, do you know if there's a way to intercept browser navigation too (back and forward)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a workaround to show the "prevent leave" modal when users click the browser back button with unsaved changes. This solution addresses a limitation in Next.js App Router which doesn't provide built-in hooks for intercepting browser history navigation events.
Technical details:
Note: This implementation specifically targets the browser back button use case, which covers the vast majority of user navigation patterns. Forward button navigation is not supported by this workaround, but I think this is an acceptable trade-off considering the complexity of fully emulating the browser's history behavior within a Next.js application.
Screen.Recording.2025-04-10.at.11.56.58.mov