fix(ui): reflect default sort in join tables #12084
Open
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to set default state
coreyleelarson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR ensures defaultSort is reflected in join tables.
Why?
Currently, default sort is not reflected in the join table state. The data is sorted correctly, but the table state sort is undefined. This is mainly an issue for join fields with
orderable: truebecause you can't re-order the table untilorderis the selected sort column.How?
Added
defaultSortprop to the<ListQueryProvider />in the<RelationshipTable />and ensured the default state gets set in<ListQueryProvider />whenmodifySearchParamsis false.Before:
After:
Fixes #12083