Skip to content

test: fix group-by suite flakes #16816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denolfe merged 1 commit into from
Jun 1, 2026
Merged

test: fix group-by suite flakes #16816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions test/__helpers/e2e/filters/openListFilters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,23 @@ export const openListFilters = async (
): Promise<{
filterContainer: Locator
}> => {
await expect(page.locator(togglerSelector)).toBeVisible()
const filterContainer = page.locator(filterContainerSelector).first()
const toggler = page.locator(togglerSelector).first()
await expect(toggler).toBeVisible()

const isAlreadyOpen = await filterContainer.isVisible()
// Drive the drawer open off the toggler's `aria-expanded` state (the source of truth)
// rather than a point-in-time visibility check of the container. The container flickers
// visible mid-animation, and a preceding re-render (e.g. a group-by/sort change) can drop
// the open click before it updates React state. Retrying the toggle until `aria-expanded`
// reports open makes this idempotent and resilient to that race.
await expect(async () => {
if ((await toggler.getAttribute('aria-expanded')) !== 'true') {
await toggler.click()
}

if (!isAlreadyOpen) {
await page.locator(togglerSelector).first().click()
}
await expect(toggler).toHaveAttribute('aria-expanded', 'true')
}).toPass()

await expect(page.locator(`${filterContainerSelector}.rah-static--height-auto`)).toBeVisible()

return { filterContainer }
return { filterContainer: page.locator(filterContainerSelector).first() }
}
Loading