fix(richtext-lexical): order=0 being sorted to the end of the toolbar#17090
Open
beheh wants to merge 1 commit into
Open
fix(richtext-lexical): order=0 being sorted to the end of the toolbar#17090beheh wants to merge 1 commit into
beheh wants to merge 1 commit into
Conversation
Author
|
I've observed this @payloadcms/richtext-lexical@3.79.0 but have targeted main for now - not sure if you'll backport, or not, or if I should've opened against 3.X and this would've been ported to 4.X. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The following lexical editor
features.BlocksFeatureconfig:...currently results in a mis-sorted dropdown:
...where my custom "BoxBlockConfig" is at the end.
Why?
Because the sorting component does not consider false-y orders valid, the item with the index 0 is incorrectly sorted to the end.
How?
Switching to an explicit non-null check keeps the defensiveness while fixing this: