fix(ui): resolve card aria-label showing [object Object] for localized labels#17096
Open
ikhana wants to merge 1 commit into
Open
fix(ui): resolve card aria-label showing [object Object] for localized labels#17096ikhana wants to merge 1 commit into
ikhana wants to merge 1 commit into
Conversation
ikhana
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The
createNewLabelaria-label on collection card buttons displays[object Object]instead of the localized collection name when collection labels are defined as multilingual objects (e.g.,{ en: 'Pages', de: 'Seiten' }).Why?
Line 106 in
CollectionCards/index.tsxpasses the rawlabelobject directly to thet()translation function. Sincelabelis an object (not a string), JavaScript coerces it to[object Object]. The other translation calls in the same file (showAllLabelon line 50,editLabelon line 68-69) already resolve the label correctly — this one was missed.How?
Changed
labeltolabel: titleon line 106, wheretitleis already resolved viagetTranslation(label, i18n)on line 48. One-line change, consistent with the existing pattern in the same file.Fixes #17069