Open
Conversation
Collaborator
sshropshire
commented
Dec 1, 2025
sshropshire
commented
- This PR contains changes to align with Android Jetpack best practices as demonstrated in the android/nowinandroid app.
- This is a feature branch that contains all of the changes made from previously reviewed PRs
This reverts commit 3a20c99.
* Make PayPalViewModel a hilt view model. * Add new intent effect to composable to process new intents from Jetpack compose. * Add intermediary PayPal screen. * Update PayWithPayPal checkout flow with a retry button. * Implement PayPal confirm retry. * Fix rebase errors. * Add back payment link button. * Clean up.
* Implement PayWithPaymentLink. * Extract BrowserSwitchLauncher. * Remove unused methods. * Remove CheckoutCoordinator ViewModel. * Remove redundant PaymentLinkCompleteView. * Fix imports. * Remove unused imports. * Refactor Payment Link flow to recover when flow is canceled by user. * Fix broken URLs. * Use new finish method on PayPal view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.