Align package.json with upstream + clarify tabs permission is optional - #7
Merged
Conversation
- package.json: match Rakuten's version (0.4.1) and devDep versions so the upstream PR carries only feature code, no version bump / dep changes - README: expand Installation with permission guidance; document that the 'tabs' permission is optional on Chrome/Firefox/Edge (Safari keeps it) - api/index.ts: fix missing-API warning to match (tabs optional on Chrome/FF/Edge)
…ples The tabs permission is optional on Chrome/Firefox/Edge (tabs.onRemoved fires without it), so the minimal manifest examples now show only webRequest. Safari and cross-browser examples keep tabs (Safari requires it).
…ction Line 417 still listed tabs as required for Chrome/FF/Edge; align it with the tabs-optional change made elsewhere in this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Cleans up
paypal:mainso the outgoing Rakuten PR (#1) carries only feature code — no version bump, no dependency changes — and documents thetabspermission accurately.Changes
package.json— align with Rakuten'smainso the upstream PR shows zero package.json diff:version:0.5.0→0.4.1(Rakuten controls their own versioning; keepsmaina clean mirror)@types/chrome,@types/node,eslint) — no longer downgrades themREADME.md— expand Installation with permission guidance; document that thetabspermission is optional on Chrome/Firefox/Edge (the SDK only listens totabs.onRemoved, which reads no sensitive tab data). Safari keepswebNavigation+tabs.src/api/index.ts— fix the missing-APIconsole.warnto match:tabsis optional on Chrome/FF/Edge.Validation
tsc --noEmitcleanNotes
tabs-optional claim is scoped to Chrome/Firefox/Edge only; Safari behavior was not verified, so it conservatively keepstabs.🤖 Generated with Claude Code