Revert "first version of changes to avoid accidental worker state update during worker recovery"#410
Merged
rasamala83 merged 10 commits intomainfrom Feb 4, 2025
Conversation
This reverts commit 44bebff.
…cution" This reverts commit c00b147.
This reverts commit 02c1500.
This reverts commit 8db5c70.
…tor" This reverts commit 957b0de.
This reverts commit eeb2943.
This reverts commit cd92e68.
…ontrol state updates" This reverts commit 24e2039.
This reverts commit 363564d.
…ate during worker recovery" This reverts commit 8739920.
ishi-0987
approved these changes
Feb 4, 2025
Collaborator
ishi-0987
left a comment
ishi-0987
left a comment
There was a problem hiding this comment.
Looks good.
It is a revert PR. No new Code.
venkatsridhar95
added a commit
that referenced
this pull request
Mar 5, 2025
#417) remove unwanted log message instead of flow based control added valid transition map to control state updates update test code based on state transition map added missing transtion from finish state to scheduled state remove restart worker logic as it will taken care worker monitor move process reaping login go from C fixing race condition related to worker recovery issue removed unwanted changes related to induced delays during execution fixin functional test comparision Revert "first version of changes to avoid accidental worker state update during worker recovery" (#410) * Revert "fixin functional test comparision" This reverts commit 44bebff. * Revert "removed unwanted changes related to induced delays during execution" This reverts commit c00b147. * Revert "fixing race condition related to worker recovery issue" This reverts commit 02c1500. * Revert "move process reaping login go from C" This reverts commit 8db5c70. * Revert "remove restart worker logic as it will taken care worker monitor" This reverts commit 957b0de. * Revert "added missing transtion from finish state to scheduled state" This reverts commit eeb2943. * Revert "update test code based on state transition map" This reverts commit cd92e68. * Revert "instead of flow based control added valid transition map to control state updates" This reverts commit 24e2039. * Revert "remove unwanted log message" This reverts commit 363564d. * Revert "first version of changes to avoid accidental worker state update during worker recovery" This reverts commit 8739920. Non graceful worker recovery issues and workflow issue (#411) * changes for adding atomic checks while sending and relading data during worker recovery * fixing the workflow issues Co-authored-by: Rajesh Samala <rasamala@paypal.com>
vineravi
pushed a commit
that referenced
this pull request
Mar 24, 2025
…ate during worker recovery" (#410) * Revert "fixin functional test comparision" This reverts commit 44bebff. * Revert "removed unwanted changes related to induced delays during execution" This reverts commit c00b147. * Revert "fixing race condition related to worker recovery issue" This reverts commit 02c1500. * Revert "move process reaping login go from C" This reverts commit 8db5c70. * Revert "remove restart worker logic as it will taken care worker monitor" This reverts commit 957b0de. * Revert "added missing transtion from finish state to scheduled state" This reverts commit eeb2943. * Revert "update test code based on state transition map" This reverts commit cd92e68. * Revert "instead of flow based control added valid transition map to control state updates" This reverts commit 24e2039. * Revert "remove unwanted log message" This reverts commit 363564d. * Revert "first version of changes to avoid accidental worker state update during worker recovery" This reverts commit 8739920.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #408 due to PR ID not showing in commit history