Skip to content

add QRCode component to hosted buttons #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

jshawl
Copy link
Contributor

@jshawl jshawl commented Mar 4, 2024

Description

This PR fixes an issue where buyers checking out with Venmo on Desktop receive a native_error.

Why are we making these changes?

Desktop buyers are unable to complete a checkout using the Venmo button for hosted button experiences.

Reproduction Steps (if applicable)

Load this hosted button example in a browser and click on the venmo button.

<script src=[https://www.paypal.com/sdk/js?client-id=BAASQz64f1YcDfoz5jgt15dL2BGNcDZ5Mb_pAFQ6TgEk7fB3eE7WHpPU8v1cySkLIc6YaJ7ajwbdhiICCM&components=buttons,hosted-buttons&enable-funding=venmo&currency=USD](view-source:https://www.paypal.com/sdk/js?client-id=BAASQz64f1YcDfoz5jgt15dL2BGNcDZ5Mb_pAFQ6TgEk7fB3eE7WHpPU8v1cySkLIc6YaJ7ajwbdhiICCM&components=buttons,hosted-buttons&enable-funding=venmo&currency=USD)></script>
<div id="paypal-container-CQ2ZWHMMN7UD2"></div>
<script>
  paypal.HostedButtons({
    hostedButtonId: "CQ2ZWHMMN7UD2",
  }).render("#paypal-container-CQ2ZWHMMN7UD2")
</script>

Screenshots (if applicable)

Screenshot 2024-03-04 at 15 41 44

Follow-Up Work

  • Investigate aliasing hosted-buttons to the buttons component so that new components (e.g. venmo web) will automatically be picked up without editing this file
  • Investigate supporting the QRcode checkout experience in sandbox (today it is the popup window)

❤️ Thank you!

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.00%. Comparing base (bcdf9c3) to head (209c114).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2351   +/-   ##
=======================================
  Coverage   58.00%   58.00%           
=======================================
  Files         153      153           
  Lines       12232    12232           
  Branches      742      742           
=======================================
  Hits         7095     7095           
  Misses       5041     5041           
  Partials       96       96           
Flag Coverage Δ
jest 32.12% <ø> (ø)
karma 50.17% <ø> (ø)
vitest 54.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jshawl jshawl marked this pull request as ready for review March 5, 2024 14:34
@jshawl jshawl requested a review from a team as a code owner March 5, 2024 14:34
@jshawl jshawl marked this pull request as draft March 5, 2024 14:39
@jshawl jshawl marked this pull request as ready for review March 6, 2024 16:31
@jshawl jshawl merged commit 648b54d into main Mar 6, 2024
3 checks passed
@jshawl jshawl deleted the fix-venmo-qr-code-hosted-buttons branch March 6, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants