-
Notifications
You must be signed in to change notification settings - Fork 578
feat: message hover and click behavior and modal #2352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Seavenly
merged 17 commits into
feature/dynamic-messaging
from
feature/btn-msg-click-logic1
Mar 28, 2024
Merged
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
036c47c
fixes message props to alert when passed empty strings
danzhaaspaypal 7f95638
adds onMessageHover and onMessageClick props and loads modal
danzhaaspaypal f7d8c25
modal renders
danzhaaspaypal 2330ed5
browser utilizes MessagesModal from messages component if available i…
danzhaaspaypal a1c3e13
reuses modal instance, allows namespace flexibility, and reorganizes …
danzhaaspaypal 8c7fadc
cleans code and adds tests
danzhaaspaypal c6afc99
fixes getModal Promise
danzhaaspaypal 756b664
tests WIP
danzhaaspaypal b403f93
tests WIP cont'd
danzhaaspaypal 1d640d7
tests pass
danzhaaspaypal 3035a72
fixes lint issues
danzhaaspaypal ec093f9
cleans code
danzhaaspaypal 976ede2
feat: button message instrumentation (#2360)
paypal-rosman 41e2284
Merge branch 'feature/btn-msg-click-logic1' of https://github.com/pay…
danzhaaspaypal 77500c6
increments alpha version for release for e2e trial
danzhaaspaypal 6128e68
cleans code
danzhaaspaypal b7a2e29
cleans code
danzhaaspaypal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.