Re-add Shopper Insights #2354
Re-add Shopper Insights #2354
Conversation
Co-authored-by: elizabethmv <[email protected]> Co-authored-by: Shane Brunson <[email protected]>
wsbrunson
force-pushed
the
shopper-insights-redux
branch
from
923bb9e to
20ff8a4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2354 +/- ##
==========================================
- Coverage 58.00% 51.20% -6.80%
==========================================
Files 153 154 +1
Lines 12232 12527 +295
Branches 742 726 -16
==========================================
- Hits 7095 6415 -680
- Misses 5041 6008 +967
- Partials 96 104 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
||
| if (!isValidPhone) { | ||
| throw new ValidationError( | ||
| `Expected shopper information to be a valid phone number format` |
There was a problem hiding this comment.
might be helpful to end users to include the format, like:
`Expected shopper information to be a valid phone number format: /\d{5,}/`
There was a problem hiding this comment.
Thats good suggestion. We are going to have some changes on the interface. I will take a note to update the validation message with the next PR.
| ...(sdkConfig.environment !== "production" && { | ||
| country_code: sdkConfig.buyerCountry, | ||
| }), | ||
| // $FlowIssue too many cases? |
There was a problem hiding this comment.
this ^ happened to me recently - frustrating! (maybe we can ignore it in the near future)
No description provided.