update axo loader library #2355
Conversation
wsbrunson
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2355 +/- ##
=======================================
Coverage ? 58.00%
=======================================
Files ? 153
Lines ? 12232
Branches ? 742
=======================================
Hits ? 7095
Misses ? 5041
Partials ? 96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -1,5 +1,5 @@ | |||
| /* @flow */ | |||
| import { loadAxo } from "@paypal/connect-loader-component"; | |||
| import { loadAxo } from "@paypal/accelerated-checkout-loader/dist/loader.esm"; | |||
There was a problem hiding this comment.
Can we make the loader a top level export from this package? Bit worried that importing nested dependencies can create issues with future refactorings in this component.
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. |
Reverts the revert. This is re-adding the updated axo library