Skip to content

Remove cdnify script #2358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Remove cdnify script #2358

merged 1 commit into from
Mar 13, 2024

Conversation

nbierdeman
Copy link
Contributor

@nbierdeman nbierdeman commented Mar 8, 2024

Description

This PR removes the cdnify script entirely. Do we want to do this or leave it for running locally?

Jira

DTPPCPSDK-1978

@nbierdeman nbierdeman requested a review from a team March 8, 2024 15:06
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.27%. Comparing base (59cad3d) to head (030b14e).

Additional details and impacted files
@@            Coverage Diff             @@
##               v4    #2358      +/-   ##
==========================================
+ Coverage   69.17%   69.27%   +0.09%     
==========================================
  Files          92       92              
  Lines        3105     3105              
  Branches      183      183              
==========================================
+ Hits         2148     2151       +3     
+ Misses        877      874       -3     
  Partials       80       80              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jshawl jshawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nbierdeman nbierdeman merged commit b45a658 into v4 Mar 13, 2024
2 checks passed
@nbierdeman nbierdeman deleted the remove-cdnify-script branch March 13, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants