Button Color A/B Test #2469
Merged
Button Color A/B Test #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnguyen510
approved these changes
Feb 18, 2025
ravishekhar
approved these changes
Mar 7, 2025
|
|
||
| const { paylater } = fundingEligibility; | ||
|
|
||
| const shouldResizeLabel = |
There was a problem hiding this comment.
just a nit, we could derive this value in server and set this value in globals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support A/B Test of the new default blue color. There will be a light and dark blue options test, along side our current default gold color.
This is the first step in the PayPal button rebrand.
https://paypal.atlassian.net/browse/DTPPCPSDK-1825
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Reproduction Steps (if applicable)
Screenshots (if applicable)
FPTI Button Color Verification
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!