add timing data to xprops #2471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsbrunson
force-pushed
the
add-timings
branch
from
04fb010 to
1deff7a
Compare
wsbrunson
force-pushed
the
add-timings
branch
from
1deff7a to
8679586
Compare
imbrian
reviewed
Feb 18, 2025
| return "unknown"; | ||
| } | ||
|
|
||
| return performanceEntry.duration === 0 ? "yes" : "no"; |
There was a problem hiding this comment.
Is this yes/no standard for existing performance queries that we have?
There was a problem hiding this comment.
its what we did in nextgen. normally I would have done true/false but the presence of unknown made me go a different direction.
I'm not sure of any precedent for this type of thing, I'm open to suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add sdk init time from
sdk-clientas well as thedurationproperty from the first sdk script loaded on the page.We will use this information in the buttons iframe to mark sdk init end and also report on the duration of the sdk load time on the merchant's page