Appswitch web fallback return flow #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsbrunson
approved these changes
Mar 7, 2025
hnguyen510
reviewed
Mar 7, 2025
| }); | ||
|
|
||
| test("should test onCancel resume params when parameters are passed from web fallback", () => { | ||
| vi.spyOn(window, "location", "get").mockReturnValue({ |
There was a problem hiding this comment.
Hi Ravi, for learning, can you explain more about how spyOn() being used? instead of just mocking the values, why do you need to spyOn and then mock it?
There was a problem hiding this comment.
I wanted to avoid overriding the global objects with mock functions, as that requires ensuring we reset in afterEach hooks.
The Spies provided by vitest does this for free by only overriding the return values instead of overriding the method itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Reproduction Steps (if applicable)
Screenshots (if applicable)
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!