Skip to content

update return url query params #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

update return url query params #2483

merged 1 commit into from
Mar 21, 2025

Conversation

ravishekhar
Copy link
Contributor

Description

  • Expect button_session_id in the return URL query params
  • Use approval_token_id and approval_session_id as vaultSetupToken

Why are we making these changes? Include references to any related Jira tasks or GitHub Issues

Reproduction Steps (if applicable)

Screenshots (if applicable)

Dependent Changes (if applicable)

Groups who should review (if applicable)

❤️ Thank you!

@ravishekhar ravishekhar marked this pull request as ready for review March 20, 2025 21:42
@ravishekhar ravishekhar requested a review from a team as a code owner March 20, 2025 21:42
@ravishekhar ravishekhar merged commit b700997 into main Mar 21, 2025
3 checks passed
@ravishekhar ravishekhar deleted the return_url_params branch March 21, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbrian imbrian imbrian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ravishekhar @imbrian