Errors with strict CSP for inline styling, nonces added to <style>. #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SP. Nonce added to style tags that were resulting in errors being thrown
ravishekhar
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is in response to a LI where a merchant was encountering inline-styling errors with their CSP and their CSP does not allow for the use of 'unsafe-inline'
To address these issues, a nonce was added to the <style> tags that were throwing these errors.
LI: https://paypal.atlassian.net/browse/LI-84820
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Ticket: https://paypal.atlassian.net/browse/DTPPCPSDK-3080
Not all styling had a nonce with it and it was causing errors with a merchant's Content Security Policy.
Reproduction Steps (if applicable)
Test bed to reproduce error is provided in the comments under the LI link above.
Example error: 'Refused to apply inline style because it violates the following Content Security Policy directive: "style-src 'self' 'nonce-...'
Screenshots (if applicable)
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!